Home
Reading
Searching
Subscribe
Sponsors
Statistics
Posting
Contact
Spam
Lists
Links
About
Hosting
Filtering
Features Download
Marketing
Archives
FAQ
Blog
 
Gmane
From: Pieter Praet <pieter-boLSHHvTtrjYtjvyW6yDsg <at> public.gmane.org>
Subject: Re: [PATCH v2] emacs: call notmuch-show instead of notmuch-search in buttonised id: links
Newsgroups: gmane.mail.notmuch.general
Date: Thursday 12th January 2012 17:20:12 UTC (over 5 years ago)
On Thu, 22 Dec 2011 20:59:12 -0800, Jameson Graef Rollins
 wrote:
> Since message-ids necessarily match just a single message, there's no
> reason to do a search for the id before viewing the actual message;
> the search just becomes an extra screen to click through.  Clicking on
> an id: links now just jumps straight to the message itself.
> ---
> This just fixes the subject of the patch, which had a typo.  Sorry.
> 
>  emacs/notmuch-show.el |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
> index 98db8f2..623d521 100644
> --- a/emacs/notmuch-show.el
> +++ b/emacs/notmuch-show.el
> @@ -803,7 +803,7 @@ a corresponding notmuch search."
>        (remove-overlays (match-beginning 0) (match-end 0) 'goto-address
t)
>        (make-text-button (match-beginning 0) (match-end 0)
>  			'action `(lambda (arg)
> -				   (notmuch-search ,(match-string-no-properties 0)))
> +				   (notmuch-show ,(match-string-no-properties 0)))
>  			'follow-link t
>  			'help-echo "Mouse-1, RET: search for this message"
>  			'face goto-address-mail-face))))
> -- 
> 1.7.7.3

Anti-RSI FTW!

However...  If no message with that id: exists, `notmuch-show'
will drop us to a blank screen.

See
id:"87lisjzrsc.fsf-clhehnSHAb8h2wMQzzS[email protected]"
for some mock
'id:' links which demonstrate this nicely.

Patches follow.


Peace

-- 
Pieter
 
CD: 3ms