On Fri, 19 Dec 2008 00:07:33 +0100
Bernd Schubert wrote:
> On Thursday 18 December 2008, Andrew Morton wrote:
> > On Thu, 18 Dec 2008 09:24:20 -0500
> > Christoph Hellwig wrote:
> > > On Thu, Dec 18, 2008 at 10:44:18PM +1100, Stephen Rothwell wrote:
> > > > Added from today.
> > > >
> > > > Usual spiel: all patches in that branch must have been
> > > > posted to a relevant mailing list
> > > > reviewed
> > > > unit tested
> > > > destined for the next merge window (or the current release)
> > > > *before* they are included.
> > >
> > > I don't think we want fscache for .29 yet. I'd rather let the
> > > credential code settle for one release, and have more time for
> > > reviewing it properly and have it 100% ready for .30.
> > I don't believe that it has yet been convincingly demonstrated that we
> > want to merge it at all.
> > It's a huuuuuuuuge lump of new code, so it really needs to provide
> > decent value. Can we revisit this? Yet again? What do we get from
> > all this?
> I really don't understand why fs-cache is always rejected.
It's never been rejected. For a long time it has been in a state where
we're looking for the data which would allow us to agree that its
benefits are worth its costs. AFAIK that has never really been
convincingly demonstrated. Nor has the converse case been
demonstrated, so it floats in limbo.
> Actually it is the
> perfect solution for NFS booted systems - you have a big cluster of nodes
> in order to minimize administration overhead the nodes are booted over
> from one common chroot. With unionfs (preferred solution here is
> one then maintains files required to be differently by different clients.
> Caching files on the local disk minimized the network access and boosts
> performance, so at least for this usage example fs-cache would be great.
> (Actually I have been thinking about to implement a caching branch into
> unionfs-fuse, but if the kernel can do it on its own, it is also fine.)
Have you actually used cachefs/cachefiles for this?
> In the past David already posted many benchmarks and just a few weeks ago
OK, benchmarks are good. But look:
303 files changed, 21049 insertions(+), 3726 deletions(-)
it's an enormous hunk of code. That will be in the kernel for ever and
ever, needing maintenance, adding additional burden to our effort to
evolve the kernel, etc.
Are any distros pushing for this? Or shipping it? If so, are they
able to weigh in and help us with this quite difficult decision?