|
Subject: Re: [PATCHv4 5/6] Allow setting O_NONBLOCK flag for new sockets Newsgroups: gmane.linux.kernel Date: 2007-11-20 07:59:44 GMT (1 year, 32 weeks, 3 days, 10 hours and 54 minutes ago) From: Ulrich Drepper <drepper <at> redhat.com> Date: Tue, 20 Nov 2007 01:53:14 -0500 FWIW, I think this indirect syscall stuff is the most ugly interface I've ever seen proposed for the kernel. And I agree with all of the objections raised by both H. Pater Anvin and Eric Dumazet. > This patch adds support for setting the O_NONBLOCK flag of the file > descriptors returned by socket, socketpair, and accept. ... > - err = sock_attach_fd(sock1, newfile1); > + err = sock_attach_fd(sock1, newfile1, > + INDIRECT_PARAM(file_flags, flags)); Where does this INDIRECT_PARAM() macro get defined? I do not see it being defined anywhere in these patches. |
|
|