Path: news.gmane.org!not-for-mail From: Adrian Bunk Newsgroups: gmane.linux.kernel Subject: [2.6 patch] fix devres_release_all() return value Date: Mon, 18 Jun 2007 01:42:54 +0200 Lines: 37 Approved: news@gmane.org Message-ID: <20070617234254.GD3588@stusta.de> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 X-Trace: sea.gmane.org 1182123811 1081 80.91.229.12 (17 Jun 2007 23:43:31 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sun, 17 Jun 2007 23:43:31 +0000 (UTC) Cc: Jeff Garzik , linux-kernel@vger.kernel.org To: Tejun Heo Original-X-From: linux-kernel-owner+glk-linux-kernel-3=40m.gmane.org-S1761490AbXFQXnM@vger.kernel.org Mon Jun 18 01:43:29 2007 Return-path: Envelope-to: glk-linux-kernel-3@gmane.org Original-Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1I04P2-0006w9-OU for glk-linux-kernel-3@gmane.org; Mon, 18 Jun 2007 01:43:29 +0200 Original-Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761490AbXFQXnM (ORCPT ); Sun, 17 Jun 2007 19:43:12 -0400 Original-Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1761904AbXFQXmj (ORCPT ); Sun, 17 Jun 2007 19:42:39 -0400 Original-Received: from emailhub.stusta.mhn.de ([141.84.69.5]:37889 "EHLO mailhub.stusta.mhn.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1761889AbXFQXmi (ORCPT ); Sun, 17 Jun 2007 19:42:38 -0400 Original-Received: from r063144.stusta.swh.mhn.de (r063144.stusta.swh.mhn.de [10.150.63.144]) by mailhub.stusta.mhn.de (Postfix) with ESMTP id A198E181C0D; Mon, 18 Jun 2007 01:45:19 +0200 (CEST) Original-Received: by r063144.stusta.swh.mhn.de (Postfix, from userid 1000) id 44BE03CE68C; Mon, 18 Jun 2007 01:42:54 +0200 (CEST) Content-Disposition: inline User-Agent: Mutt/1.5.15+20070412 (2007-04-11) Original-Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org Xref: news.gmane.org gmane.linux.kernel:544290 Archived-At: Every file should include the headers containing the prototypes for it's global functions. Since the GNU C compiler is now able to detect that the function prototype of devres_release_all() in the header and the actual function disagree regarding the return value, this patch also fixes this bug. Signed-off-by: Adrian Bunk --- drivers/base/base.h | 2 +- drivers/base/devres.c | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) --- linux-2.6.22-rc4-mm2/drivers/base/base.h.old 2007-06-17 15:37:21.000000000 +0200 +++ linux-2.6.22-rc4-mm2/drivers/base/base.h 2007-06-17 15:37:34.000000000 +0200 @@ -44,6 +44,6 @@ extern char *make_class_name(const char *name, struct kobject *kobj); -extern void devres_release_all(struct device *dev); +extern int devres_release_all(struct device *dev); extern struct kset devices_subsys; --- linux-2.6.22-rc4-mm2/drivers/base/devres.c.old 2007-06-17 15:30:48.000000000 +0200 +++ linux-2.6.22-rc4-mm2/drivers/base/devres.c 2007-06-17 15:31:03.000000000 +0200 @@ -10,6 +10,8 @@ #include #include +#include "base.h" + struct devres_node { struct list_head entry; dr_release_t release;