Gmane
Favicon
From: Greg KH <gregkh <at> suse.de>
Subject: [PATCH] Driver core: Use klist_del() instead of klist_remove().
Newsgroups: gmane.linux.kernel
Date: 2005-06-30 06:04:22 GMT (4 years, 4 days, 16 hours and 12 minutes ago)
[PATCH] Driver core: Use klist_del() instead of klist_remove().

Use klist_del() instead of klist_remove() when unregistering devices.
This will prevent a deadlock when executing a recursive unregister using
device_for_each_child().

Signed-off-by Patrick Mochel <mochel <at> digitalimplant.org>
Signed-off-by: Greg Kroah-Hartman <gregkh <at> suse.de>

---
commit d62c0f9fd2d3943a3eca85b490d86e1605000ccb
tree c9fc174992f7746f680becdeaa1bdb6924108c0f
parent 23d3d602cb96addd3c1158424fb01a49ea5e81b1
author Patrick Mochel <mochel <at> digitalimplant.org> Fri, 24 Jun 2005 08:39:33 -0700
committer Greg Kroah-Hartman <gregkh <at> suse.de> Wed, 29 Jun 2005 22:48:05 -0700

 drivers/base/core.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/base/core.c b/drivers/base/core.c
--- a/drivers/base/core.c
+++ b/drivers/base/core.c
@@ -333,7 +333,7 @@ void device_del(struct device * dev)
 	struct device * parent = dev->parent;

 	if (parent)
-		klist_remove(&dev->knode_parent);
+		klist_del(&dev->knode_parent);

 	/* Notify the platform of the removal, in case they
 	 * need to do anything...