Features Download
From: Michel Lespinasse <walken <at> google.com>
Subject: [PATCH 00/12] rwsem fast-path write lock stealing
Newsgroups: gmane.linux.kernel
Date: Wednesday 6th March 2013 23:21:39 UTC (over 3 years ago)
These patches extend Alex Shi's work (which added write lock stealing
on the rwsem slow path) in order to provide rwsem write lock stealing
on the fast path (that is, without taking the rwsem's wait_lock).

I initially sent a shorter series shortly before v3.9, however some
patches were doing too much at once which made them confusing to
review. I have now split the series at a smaller granularity;
hope this will help :)

Patches 1-2 are for cleanups:

- Patch 1 replaces the waiter type bitmask with an enumeration
  (as we don't have any other planned uses for the bitmap)

- Patch 2 shortens critical sections in rwsem_down_failed_common() so
  they don't cover more than what is absolutely necessary

Patches 3-5 splits rwsem_down_failed_common() into separate functions
for the read and write sides:

- Patch 3 simply puts two identical copies of rwsem_down_failed_common()
  into rwsem_down_{read,write}_failed (no code changes, in order to
  make the review easier)

- Patch 4 does easy simplifications in rwsem_down_read_failed():
  - We don't need to wake readers queued before us;
  - We don't need to try to steal the lock, and thus we don't need to
    acquire the wait_lock after sleeping.

- Patch 5 does easy simplifications in rwsem_down_write_failed():
  - We don't need to check for !waiter.task since __rwsem_do_wake()
    doesn't remove writers from the wait_list;
  - Since the only way to exit the wait loop is by stealing the write lock,
    the corresponding exit code can be moved after the loop;
  - There is no point releaseing the wait_lock before entering the
    wait loop, as we will need to reacquire it immediately;
  - We don't need to get a reference on the task structure, since the task
    is responsible for removing itself from the wait_list;

Patches 6-9 apply additional optimizations to rwsem_down_write_failed():

- Patch 6 tries write lock stealing more aggressively in order to avoid
  extra checks;

- Patch 7 uses cmpxchg to implement the write lock stealing, instead of
  doing an additive adjustment that might need to be backed out;

- Patch 8 avoids taking the wait_lock if there are already active locks
  when we wake up;

- Patch 9 avoids the initial trylock if there were already active locks
  when we entered rwsem_down_write_failed()

Patches 10-11 wake all readers whenever the first waiter is a reader:

- Patch 10 does this in rwsem-spinlock. This is both for symetry with
  the other rwsem implementation, and because this should result in
  increased parallelism for workloads that mix readers and writers.

- Patch 11 does this in rwsem. This is partly for increased parallelism,
  but the main reason is that it gets rid of a case where __rwsem_do_wake
  assumed that the rwsem lock can't be stolen when it holds the wait_lock
  and the rwsem count indicates there are queued waiters. This assumption
  won't be true after patch 12, so we need to fix __rwsem_do_wake and it
  turns out the easiest fix involves waking all readers.

Patch 12 finally implements rwsem fast path lock stealing for x86 arch.

Michel Lespinasse (12):
  rwsem: make the waiter type an enumeration rather than a bitmask
  rwsem: shorter spinlocked section in rwsem_down_failed_common()
  rwsem: move rwsem_down_failed_common code into
  rwsem: simplify rwsem_down_read_failed
  rwsem: simplify rwsem_down_write_failed
  rwsem: more agressive lock stealing in rwsem_down_write_failed
  rwsem: use cmpxchg for trying to steal write lock
  rwsem: avoid taking wait_lock in rwsem_down_write_failed
  rwsem: skip initial trylock in rwsem_down_write_failed
  rwsem-spinlock: wake all readers when first waiter is a reader
  rwsem: wake all readers when first waiter is a reader
  x86 rwsem: avoid taking slow path when stealing write lock

 arch/x86/include/asm/rwsem.h |  28 +++--
 include/linux/rwsem.h        |   2 +
 lib/rwsem-spinlock.c         |  54 ++++-----
 lib/rwsem.c                  | 272
 4 files changed, 166 insertions(+), 190 deletions(-)

CD: 3ms