Home
Reading
Searching
Subscribe
Sponsors
Statistics
Posting
Contact
Spam
Lists
Links
About
Hosting
Filtering
Features Download
Marketing
Archives
FAQ
Blog
 
Gmane
From: Steven Rostedt <rostedt <at> goodmis.org>
Subject: [RFC][PATCH] tracing: Remove useless 4 bytes of padding from every event
Newsgroups: gmane.linux.kernel
Date: Wednesday 16th May 2012 13:44:31 UTC (over 4 years ago)
Now that PowerTop v2 is out, which uses the parse-event library, it no
longer is broken by the removal of the lock-depth field from every
event. Currently we add 4 bytes of empty space to every event. If we
have 1 million events, 4 million bytes are wasted in the ring buffers
(for both ftrace and perf).

But this change will break PowerTop v1. Thus my question is, how long do
we need to keep this wasted space in the ring buffers to satisfy an out
of date tool?

Signed-off-by: Steven Rostedt 

diff --git a/include/linux/ftrace_event.h b/include/linux/ftrace_event.h
index 5f3f3be..f96dfef 100644
--- a/include/linux/ftrace_event.h
+++ b/include/linux/ftrace_event.h
@@ -49,7 +49,6 @@ struct trace_entry {
 	unsigned char		flags;
 	unsigned char		preempt_count;
 	int			pid;
-	int			padding;
 };
 
 #define FTRACE_MAX_EVENT						\
 
CD: 4ms