Home
Reading
Searching
Subscribe
Sponsors
Statistics
Posting
Contact
Spam
Lists
Links
About
Hosting
Filtering
Features Download
Marketing
Archives
FAQ
Blog
 
Gmane
From: Andrew Morton <akpm <at> linux-foundation.org>
Subject: Re: [PATCH] leds: Fix warnings when PM is disabled for BD2802
Newsgroups: gmane.linux.kernel
Date: Saturday 22nd January 2011 00:23:25 UTC (over 5 years ago)
On Fri, 21 Jan 2011 15:38:37 -0800 Dmitry Torokhov
 wrote:

> > That rather sucks.  It leaves an all-zeroes instance of dev_pm_ops
> > uselessly bloating the driver.
> 
> It is per-driver, not per device so do we really care?

We care about everything.  If the objective was to make life easier for
ourselves, we'd all be on the golf course.

> >  And it leaves
> > bd2802_i2c_driver.driver.pm pointing at that all-zeroes instance of
> > dev_pm_ops, which is rather dangerous.
> 
> Nothing dagerous here - PM core deals with half-filled pm_ops just fine.
> 
> > 
> > If CONFIG_PM_SLEEP=n, the .driver.pm field shouldn't exist at all.
> 
> Meh, we have _waaay_ too many config options, I'd rather see CONFIG_PM
> and possibly CONFIG_PM_SLEEP go, maybe leaving us with
> CONFIG_PM_RUNTIME and maybe not. How many devices out there do not want
> PM?

Don't know.  How do we determine this?
 
CD: 3ms