Gmane
From: Eric Malkowski <eric <at> bvwireless.net>
Subject: 0.9.4.1 branch and Release 0.9.4 missing Ticket #539 fix changeset 2225
Newsgroups: gmane.linux.drivers.madwifi.user
Date: 2008-09-04 20:13:35 GMT (11 weeks, 12 hours and 37 minutes ago)
Hi all-

I was playing w/ hostapd 0.5.10 on latest madwifi 0.9.4 branch and ran 
into the Ticket #539 problem where the IEEE80211_IOCTL_SETMLME would 
fail since at hostapd at startup sets the interface down (and seems to 
continue to fail w/ EINVAL when a station tries to get going).

I was using Release 0.9.4 for stability and then went to 
svn.madwifi.org/madwifi/branches/madwifi-0.9.4/HEAD since I'm using 
latest linux kernel 2.6.26.3 so it would compile ok.

I noticed the code for changeset 2225 in ieee80211_wireless.c that 
allows MLME DISASSOC DEAUTH and UNAHTHORIZE operations while the card 
has the interface down is not present in 0.9.4.1 (branch) or 0.9.4 
release from February, 2008 yet that change was made about a year prior 
to the 0.9.4 release in March of 2007 on the trunk.

I think that change will fix most if not all of my problem, but I'm 
wondering if I should be using some other SVN branch rather than 
madwifi-0.9.4/HEAD  where my goal is stability and compatibility with 
the latest hostapd-0.5.10 release???

I will try patching that into my copy of the code later on and test to 
see if it fixes things and report but I wanted to get some opinions from 
you guys.

The code snippet looks like this from changeset 2225

http://madwifi.org/changeset/2225

Index: /trunk/net80211/ieee80211_wireless.c
===================================================================
--- /trunk/net80211/ieee80211_wireless.c (revision 2210)
+++ /trunk/net80211/ieee80211_wireless.c (revision 2225)
@@ -3330,6 +3330,14 @@
 	struct ieee80211_node *ni;

-	if (!IS_UP(dev))
-		return -EINVAL;
+	if (!IS_UP(dev)) {
+		switch (mlme->im_op) {
+		case IEEE80211_MLME_DISASSOC:
+		case IEEE80211_MLME_DEAUTH:
+		case IEEE80211_MLME_UNAUTHORIZE:
+			return 0;
+		default:
+			return -ENETDOWN;
+		}
+	}
 	switch (mlme->im_op) {
 	case IEEE80211_MLME_ASSOC:

Thanks for any info.

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/