On Wed, 2008-08-13 at 07:15 +0000, reom wrote:
> Hi, developers~
> today i tested dfs function using madwifi-dfs source.
> i used recent version of code in madwifi-dfs.
> though there were some problems related with radar pattern, it works anyway.
> 
> but in my system, tx rate was always set to lowest one.
> debugging message shows it caused by tx retry error.
> every tx process returns tx retry error.
> 
> i think ath_slottime2timeout() is the reason of tx retry error.
> 
> in trunk source, 
> static inline int 
> ath_slottime2timeout(..)
> {
>    return (slottime * 2) + 18;
> }
> 
> in dfs source,
> static inline int 
> ath_slottime2timeout(..)
> {
>    return slottime + 18;
> }
> 
> i think trunk is right.
> and i also think you developers already knows which one is right.
>
> but because merging wasn't done yet, 

Unfortunately, the merging was done, so neither the trunk nor the DFS
branch multiply slottime by 2 anymore.  The history of the code doesn't
appear to indicate clearly who was right.  

Did you try changing that function to the one from trunk?  What is the
typical value of slottime used in that function?

-- 
Regards,
Pavel Roskin

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/