Hello!

It appears that some DFS code is never executed because a comparison  
is always wrong.

Both in the trunk and the DFS branch, sc->sc_dfs_cac_timer.data is set  
to sc in ath_attach(), but ath_newstate() compares it to vap.  Those  
variables are pointers to struct ath_softc and struct ieee80211vap  
respectively.  They cannot legitimately point to the same address in  
memory, thus the condition is always false.

The 0.9.4 branch has that code as well, except that the variable is called
sc->sc_dfswaittimer.data

The code is very old.  It was present in the original import of  
madwifi-ng (revision 1175).

Any comments will be appreciated.

-- 
Regards,
Pavel Roskin

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/