Gmane
From: Alexander Pevzner <pzz <at> pzz.msk.ru>
Subject: [PATCH] Multicast reception broken with wpa_supplicant
Newsgroups: gmane.linux.drivers.madwifi.devel
Date: 2005-08-10 20:01:36 GMT (3 years, 21 weeks, 5 days, 14 hours and 31 minutes ago)
Hello,

in the infrastructure client mode, with WPA and wpa_supplicant,
device unable to correctly receive broadcast/multicast frames from AP.

The problem is that wpa_supplicant doesn't set IEEE80211_KEY_GROUP
flag, when setting the group key (I use wpa_supplicant with driver_madwifi.c).

Although I'm not sure should this problem be fixed in the driver or
in the wpa_supplicant, I've created a one-line driver patch which
fixes the problem.

BTW, although this situation may be considered as a wpa_supplicant
bug, the driver's behavior is anyway inconsistent: by the key
index it decides that key is the group key, but neither verifies
nor enforces the IEEE80211_KEY_GROUP flag.

Yet another problem which I've noticed but not fixed: if packet
doesn't decrypt, it is not dropped, but junk is delivered instead.

The patch follows:

Index: net80211/ieee80211_wireless.c
===================================================================
--- net80211/ieee80211_wireless.c	(revision 68)
+++ net80211/ieee80211_wireless.c	(working copy)
@@ -1841,6 +1841,7 @@
 			return -EINVAL;
 		wk = &ic->ic_nw_keys[kid];
 		ni = NULL;
+		ik->ik_flags |= IEEE80211_KEY_GROUP;
 	}
 	error = 0;
 	ieee80211_key_update_begin(ic);

-- 

	Wishes, Alexander Pevzner (pzz <at> pzz.msk.ru)

-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO
September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices
Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf