Home
Reading
Searching
Subscribe
Sponsors
Statistics
Posting
Contact
Spam
Lists
Links
About
Hosting
Filtering
Features Download
Marketing
Archives
FAQ
Blog
 
Gmane
From: John Goerzen <jgoerzen <at> complete.org>
Subject: Re: Bug#531221: okular: Arbitrarily enforces DRM
Newsgroups: gmane.linux.debian.devel.general
Date: Sunday 31st May 2009 18:34:31 UTC (over 8 years ago)
tags 531221 patch
thanks

Sune Vuorela wrote:
>> 2) Patch the default to have it disabled
> 
> It's a deviation from upstream that we would have to maintain for
eternity.
> This issue is not important enough for me to put the extra required work
into 
> it

Here's the patch:

[email protected]:/tmp/kdegraphics-4.2.2/okular/conf$ diff -d -u
okular.kcfg.orig okular.kcfg
--- okular.kcfg.orig    2009-05-31 13:27:25.310927480 -0500
+++ okular.kcfg 2009-05-31 13:27:32.258926063 -0500
@@ -148,7 +148,7 @@
  
  
   
-   true
+   false
   
   
    false

I don't want to be a thorn in anybody's side here, but are you seriously
telling me that this 1-word patch is too much to maintain?  It's in a
default config file, not even in a .cpp or .h source file.

>> 3) Patch the prompt to have an "allow/deny" option
> 
> It's a deviation from upstream that we would have to maintain for
eternity.
> This issue is not important enough for me to put the extra required work
into 
> it.
> Getting the prompt options translated and patch all translation packages
is 
> also not something to be easy done, please get out of your anglocentered 
> world.

I'm sure that there are i18n templates elsewhere in KDE with similar
language that could be copied.  It is rather fallacious of you to assume
I'm making an anglo-centric remark by suggesting a dialog be improved.
Right now it sucks for everyone.  It could be made better for everyone.

> When accepting patches that upstream won't carry the maintainers have to 
> maintain it forever, thru all new upstream revisions of the software.
Some 
> times, it can be done with quilt refresh, some times it needs a much
closer 
> look at the code to get to a good enough level of understanding to
actually be 
> able to update the patch. 

First off, if upstream ever drops the patch, it is no worse than the
current situation.

Secondly, this is an incredibly trivial patch.  It is changing one word
"true" to "false" in a config file.  If only all the patches I had to
maintain were so simple!

-- John
 
CD: 2ms