Subject: Re: [StGit PATCH] mail: Ask for the SMTP credentials before sending the messages
Newsgroups: gmane.comp.version-control.git
Date: 2010-02-12 22:56:51 GMT (1 year, 51 weeks, 5 days, 3 hours and 25 minutes ago)
On Fri, 2010-02-12 at 16:11 +0000, Catalin Marinas wrote:
> The original implementation was asking for the SMTP password on every
> patch sent. This patch only asks the password once before sending or
> even editing the cover message and patches.
I don't have time to investigate at the moment, but "make test" fails in
t1900-mail.sh on the "proposed" branch, which includes this patch:
*** t1900-mail.sh ***
* ok 1: Initialize the StGIT repository
* ok 2: Put all the patches in an mbox
* ok 3: Import the mbox and compare
* FAIL 4: Put all the patches in an mbox with patch attachments
stg mail --to="Inge Ström <inge <at> example.com>" -a -m \
-t ../../templates/mailattch.tmpl > mbox1
* FAIL 5: Import the mbox containing patch attachments and compare
t1=$(git cat-file -p $(stg id) | grep ^tree)
stg pop -a &&
stg import -M mbox1 &&
t2=$(git cat-file -p $(stg id) | grep ^tree) &&
[ "$t1" = "$t2" ]
* FAIL 6: Check the To:, Cc: and Bcc: headers
stg mail --to=a <at> a --cc="b <at> b, c <at> c" --bcc=d <at> d $(stg top) -m \
-t ../../templates/patchmail.tmpl > mbox &&
test "$(cat mbox | grep -e "^To:")" = "To: a <at> a" &&
test "$(cat mbox | grep -e "^Cc:")" = "Cc: b <at> b, c <at> c" &&
test "$(cat mbox | grep -e "^Bcc:")" = "Bcc: d <at> d"
* FAIL 7: Check the --auto option
stg edit --sign &&
stg mail --to=a <at> a --cc="b <at> b, c <at> c" --bcc=d <at> d --auto $(stg top) -m \
-t ../../templates/patchmail.tmpl > mbox &&
test "$(cat mbox | grep -e "^To:")" = "To: a <at> a" &&
test "$(cat mbox | grep -e "^Cc:")" = \
"Cc: C O Mitter <committer <at> example.com>, b <at> b, c <at> c" &&
test "$(cat mbox | grep -e "^Bcc:")" = "Bcc: d <at> d"
* FAIL 8: Check the e-mail address duplicates
stg mail --to="a <at> a, b b <b <at> b>" --cc="b <at> b, c <at> c" \
--bcc="c <at> c, d <at> d, committer <at> example.com" --auto $(stg top) -m \
-t ../../templates/patchmail.tmpl > mbox &&
test "$(cat mbox | grep -e "^To:")" = "To: b b <b <at> b>, a <at> a" &&
test "$(cat mbox | grep -e "^Cc:")" = "Cc: c <at> c" &&
test "$(cat mbox | grep -e "^Bcc:")" = "Bcc: committer <at> example.com, d <at> d"
* failed 5 among 8 test(s)
make[1]: *** [t1900-mail.sh] Error 1
make[1]: Leaving directory `/home/proski/src/stgit/t'
make: *** [test] Error 2
--
Regards,
Pavel Roskin