I haven't reviewed the code in detail but if it increases performance and
is correct it is something we would like to have. I will let Björn know
(since I think he got this handed to him earlier this week). He has a lot
of other things on his plate also at the moment though. He was thinking of
separating them into multiple bifs.
Regarding the ~1s delays. I guess this is under load. This is probably due
to the fact that we still need to wait for the other schedulers. This can
be up to 2000 (or was it 4000) reductions. Other factors that increases
this delay might be a gc at the wrong moment (one scheduler just started
one before the block), NIFs or something else that doesn't take reductions
Ultimately we probably want to separate code loading completely. That would
be after R15 release though.
Den 8 november 2011 18:59 skrev Bob Ippolito :
> Would it help if we wrote some patches to make more of this work
> happen before the block? Ideally there would be no block at all, but I
> don't know enough about the internals to really make that happen.
> Here's a branch (from R14B04) where I've moved most of the heavy
> lifting (especially decoding the literal table) to before the block:
> Most of the work is just putting the LoaderState on the heap instead
> of the stack so it can be made part of the API without moving all of
> the types out as well.
> This helps in some tests I've done, but it seems that maybe just the
> action of blocking and unblocking can introduce a significant pause
> (~1 sec) under some circumstances.
> 2011/11/5 Björn-Egil Dahlberg <[email protected]>:
> > There is no other locking for code loading than blocking. This is an
> > optimization of course since locking mechanism overhead is removed from
> > equation. Code loading is not used all that often in the normal cases
> > besides startups and upgrades.
> > That being said, there are plans to remove this "stop-the-world"
> > since it is blocking other strategies and optimizations. Also, we are
> > aware of that blocking does degrade performance when loading new
> > does not agree with our concurrency policy.
> > I think we can lessen the time blocked in the current implementation
> > blocking strategy should (and probably will) be removed. Nothing
> > of yet though.
> > Regards,
> > Björn-Egil
> > 2011/11/5 Bob Ippolito
> >> We've found a bottleneck in some of our systems, when we load in large
> >> new modules there is a noticeable pause (1+ seconds) that blocks all
> >> of the schedulers. It looks like this is because the
> >> erlang:load_binary/2 BIF blocks SMP before it does anything at all.
> >> It would be a big win for us if more of this happened without blocking
> >> the VM, there's a lot of busy work in loading a module that shouldn't
> >> need any locking. For example, decompressing and decoding the literal
> >> table is probably where our code spends almost all of its time.
> >> There aren't a lot of comments for why it needs to lock the VM,
> >> especially for the whole of load_binary. Are there any hidden gotchas
> >> in here that I should know about before giving it a try? I'm unable to
> >> find much where the block is actually necessary, but I am not very
> >> familiar with the BEAM implementation yet.
> >> I expect that the erts_export_consolidate, insert_new_code and
> >> final_touch are really the only things that need so much
> >> serialization, and maybe the set_default_trace_pattern… is there
> >> anything big that I'm missing? It seems that breaking up
> >> erts_load_module into two functions (one to do all the decoding
> >> without the erts_smp_block_system(0), and the other to do the
> >> integration work with the block) would be straightforward.
> >> -bob
> >> _______________________________________________
> >> erlang-questions mailing list
> >> [email protected]
> >> http://erlang.org/mailman/listinfo/erlang-questions