Home
Reading
Searching
Subscribe
Sponsors
Statistics
Posting
Contact
Spam
Lists
Links
About
Hosting
Filtering
Features Download
Marketing
Archives
FAQ
Blog
 
Gmane
From: =?UTF-8?B?UMOhZHJhaWcgQnJhZHk=?= <P <at> draigBrady.com>
Subject: [PATCH] build: avoid unneeded spawn-pipe gnulib module
Newsgroups: gmane.comp.gnu.coreutils.general
Date: Tuesday 14th January 2014 18:46:14 UTC (over 3 years ago)
I noticed this uclibc build issue mentioned at:
http://permalink.gmane.org/gmane.comp.lib.uclibc.buildroot/73294

I sent a separate patch to gnulib to fix the direct issue there,
however I was surprised that we were using the spawn-pipe module at all.

It seems since coreutils 8.16 we've pulled in these dependencies:

  pipe
    spawn-pipe
      posix_spawnp
        posix_spawnp-internal
          spawn

The change to add "pipe" was triggered by this GNULIB_POSIXCHECK result:
 "call to 'pipe' declared with attribute warning: pipe is unportable -
  use gnulib module pipe-posix for portability [-Werror]"

So I think we really only need to include pipe-posix instead,
which is what the attached patch does.

The build error is a bit surprising as it suggests that uclibc builds
are broken since 8.16? Or maybe uclibc has recently moved posix_spawn()
-lrt?
In any case these two fixes should avoid the issue for future coreutils
releases.

thanks,
Pádraig.
 
CD: 3ms