|
Subject: Re: -var-info-path-expression Newsgroups: gmane.comp.gdb.patches Date: 2007-07-03 17:58:15 GMT (2 years, 20 hours and 29 minutes ago) On Tue, Jul 03, 2007 at 09:51:19PM +0400, Vladimir Prus wrote: > > Anyway, other than that and some comment formatting, it looks fine to me. > > What kind of formatting? Do you think you can indicate what to fix so that > I can fix it on my own without you pinpointing every problem. Two spaces again, > or something else? Yeah, that and a final period in the comment above varobj_get_path_expr. I didn't point out each one, because honestly I'm trying to be less picky about that sort of thing - it's not as if the comments weren't clear anyway. This version is OK to commit, but please wait until you have a doc patch and maybe a testcase to go with it. Thanks for being patient. -- Daniel Jacobowitz CodeSourcery |
|
|