Home
Reading
Searching
Subscribe
Sponsors
Statistics
Posting
Contact
Spam
Lists
Links
About
Hosting
Filtering
Features Download
Marketing
Archives
FAQ
Blog
 
Gmane
From: rbmj <rbmj <at> verizon.net>
Subject: Re: [PING^5] PR 54805: __gthread_tsd* in vxlib-tls.c
Newsgroups: gmane.comp.gcc.patches
Date: Wednesday 13th February 2013 21:18:53 UTC (over 4 years ago)
On 18-Jan-13 20:35, Maxim Kuvyrkov wrote:
> On 19/01/2013, at 9:18 AM, rbmj wrote:
>
>>>>   -150,7 +158,7 @@ static __gthread_once_t tls_init_guard =
>>>>      need to read tls_keys.dtor[key] atomically.  */
>>>>
>>>>   static void
>>>> -tls_delete_hook (void *tcb ATTRIBUTE_UNUSED)
>>>> +tls_delete_hook (void *tcb)
>>>
>>> Don't remove ATTRIBUTE_UNUSED.  TCB was and will remain unused #ifdef
__RTP__.
>>>
>>
>> And #ifndef __RTP__ ?
>
> No, simply leave that line as is.  ATTRIBUTE_UNUSED tells the compiler
that a variable can be unused, but not necessarily is unused.  It's fine to
have this attribute set on variables that are used under certain
preprocessor configurations.
>

Seems like I kept this email in drafts and never sent it out...

Sorry about that.

Here's the updated, (trivial) patch.

--
Robert Mason
 
CD: 62ms